Discussion:
[PATCH] b43: Add missing MODULE_FIRMWARE()
Takashi Iwai
2017-05-04 09:27:52 UTC
Permalink
Some recent firmware entries were forgotten to be added via
MODULE_FIRMWARE(), which may result in the non-functional state when
the driver is loaded in initrd.

Link: http://bugzilla.opensuse.org/show_bug.cgi?id=1037344
Signed-off-by: Takashi Iwai <***@suse.de>
---
drivers/net/wireless/broadcom/b43/main.c | 10 ++++++++++
1 file changed, 10 insertions(+)

diff --git a/drivers/net/wireless/broadcom/b43/main.c b/drivers/net/wireless/broadcom/b43/main.c
index d23aac7503d3..b37e7391f55d 100644
--- a/drivers/net/wireless/broadcom/b43/main.c
+++ b/drivers/net/wireless/broadcom/b43/main.c
@@ -71,8 +71,18 @@ MODULE_FIRMWARE("b43/ucode11.fw");
MODULE_FIRMWARE("b43/ucode13.fw");
MODULE_FIRMWARE("b43/ucode14.fw");
MODULE_FIRMWARE("b43/ucode15.fw");
+MODULE_FIRMWARE("b43/ucode16_lp.fw");
MODULE_FIRMWARE("b43/ucode16_mimo.fw");
+MODULE_FIRMWARE("b43/ucode24_lcn.fw");
+MODULE_FIRMWARE("b43/ucode25_lcn.fw");
+MODULE_FIRMWARE("b43/ucode25_mimo.fw");
+MODULE_FIRMWARE("b43/ucode26_mimo.fw");
+MODULE_FIRMWARE("b43/ucode29_mimo.fw");
+MODULE_FIRMWARE("b43/ucode33_lcn40.fw");
+MODULE_FIRMWARE("b43/ucode30_mimo.fw");
MODULE_FIRMWARE("b43/ucode5.fw");
+MODULE_FIRMWARE("b43/ucode40.fw");
+MODULE_FIRMWARE("b43/ucode42.fw");
MODULE_FIRMWARE("b43/ucode9.fw");

static int modparam_bad_frames_preempt;
--
2.12.2
Takashi Iwai
2017-05-04 09:46:34 UTC
Permalink
On Thu, 04 May 2017 11:43:14 +0200,
Post by Takashi Iwai
Some recent firmware entries were forgotten to be added via
MODULE_FIRMWARE(), which may result in the non-functional state when
the driver is loaded in initrd.
Link: http://bugzilla.opensuse.org/show_bug.cgi?id=1037344
With recent you mean three years ago? ;)
Heh, time flies :)
Some of these were added by
Rafal (CCed) in commit 15be8e89cdd99 and some in a60f99f75dd35.
Fixes: 15be8e89cdd9 ("b43: add more bcma cores")
But as this is so old bug I'll queue this to 4.13.
Thanks, it's no urgent fix, obviously. We just stumbled on this
casually.


Takashi
Kalle Valo
2017-05-22 09:03:55 UTC
Permalink
Some firmware entries were forgotten to be added via MODULE_FIRMWARE(), which
may result in the non-functional state when the driver is loaded in initrd.
Link: http://bugzilla.opensuse.org/show_bug.cgi?id=1037344
Fixes: 15be8e89cdd9 ("b43: add more bcma cores")
Patch applied to wireless-drivers-next.git, thanks.

3c89a72ad80c b43: Add missing MODULE_FIRMWARE()
--
https://patchwork.kernel.org/patch/9711225/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Loading...